Discussion:
small issue and fix with realloc in TCompactProtocol.tcc
Mario Emmenlauer
2017-11-10 10:50:33 UTC
Permalink
Hi,

I've build latest git on MacOS with clang, and found an error that
realloc is not in namespace std. I think the correct fix is to include
<cstdlib> so that realloc can be found in std. Attached is a trivial
patch, please apply. I've tested on MacOS X and Ubuntu Linux x86_64.

I sign this patch off as public domain and free to use by anyone.

All the best,

Mario Emmenlauer


--
BioDataAnalysis GmbH, Mario Emmenlauer Tel. Buero: +49-89-74677203
Balanstr. 43 mailto: memmenlauer * biodataanalysis.de
D-81669 MÃŒnchen http://www.biodataanalysis.de/
Jens Geyer
2017-11-12 13:09:21 UTC
Permalink
Hi Mario,

can we have at least a JIRA ticket for it?

Thank you!

Have fun,
JensG


-----Ursprüngliche Nachricht-----
From: Mario Emmenlauer
Sent: Friday, November 10, 2017 11:50 AM
To: ***@thrift.apache.org
Subject: small issue and fix with realloc in TCompactProtocol.tcc


Hi,

I've build latest git on MacOS with clang, and found an error that
realloc is not in namespace std. I think the correct fix is to include
<cstdlib> so that realloc can be found in std. Attached is a trivial
patch, please apply. I've tested on MacOS X and Ubuntu Linux x86_64.

I sign this patch off as public domain and free to use by anyone.

All the best,

Mario Emmenlauer
--
BioDataAnalysis GmbH, Mario Emmenlauer Tel. Buero: +49-89-74677203
Balanstr. 43 mailto: memmenlauer * biodataanalysis.de
D-81669 München http://www.biodataanal
Loading...